RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2024-12-12 22:44:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

MEDIUM: appctx/debug: force a crash if an appctx spins over itself forever

Browse Source 
If an appctx is caught spinning over itself at more than 100000 loops per
second and for more than one second, the process will be aborted and the
offender reported on the console and logs. Typical figures usually are just
a few tens to hundreds per second over a very short time so there is a huge
margin here. Using even higher values could also work but there is the risk
of not being able to catch offenders if multiple ones start to bug at the
same time and share the load. This code should ideally be disabled for
stable releases, though in theory nothing should ever trigger it.
This commit is contained in:
Willy Tarreau 2019-04-25 19:12:26 +02:00
parent 71c07ac65a
commit dcb0e1d37d
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/applet.c
View File

@ -60,6 +60,7 @@ struct task *task_run_applet(struct task *t, void *context, unsigned short state
{
struct appctx *app = context;
struct stream_interface *si = app->owner;
unsigned int rate;
if (app->state & APPLET_WANT_DIE) {
__appctx_free(app);
@ -74,7 +75,10 @@ struct task *task_run_applet(struct task *t, void *context, unsigned short state
si_rx_endp_done(si);
/* measure the call rate */
update_freq_ctr(&app->call_rate, 1);
rate = update_freq_ctr(&app->call_rate, 1);
if (rate >= 100000 && app->call_rate.prev_ctr) { // make sure to wait at least a full second
stream_dump_and_crash(&app->obj_type, read_freq_ctr(&app->call_rate));
}
/* Now we'll try to allocate the input buffer. We wake up the applet in
* all cases. So this is the applet's responsibility to check if this