RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-03-05 10:58:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: cache/cli: make "show cache" thread-safe

Browse Source 
The "show cache" command restarts from the previous node to look for a
duplicate key, but does this after having released the lock, so under
high write load, the node has many chances of having been reassigned
and the dereference of the node crashes after a few iterations. Since
the keys are unique anyway, there's no point looking for a dup, so
let's just continue from the next value.

This is only marked as medium as it seems to have been there for a
while, and discovering it that late simply means that nobody uses that
command, thus in practice it has a very limited impact on real users.

This should be backported to all stable versions.
This commit is contained in:
Willy Tarreau 2021-11-19 17:25:41 +01:00
parent 00a15025be
commit da91842b6c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cache.c
View File

@ -2589,7 +2589,7 @@ static int cli_io_handler_show_cache(struct appctx *appctx)
while (1) {
shctx_lock(shctx_ptr(cache));
if (!node || (node = eb32_next_dup(node)) == NULL)
if (!node)
node = eb32_lookup_ge(&cache->entries, next_key);
if (!node) {
shctx_unlock(shctx_ptr(cache));