RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-01-01 01:32:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: h2: properly set the direction flag on HTX response

Browse Source 
In 1.9-dev, a new flag was introduced on the start line with commit
f1ba18d7b ("MEDIUM: htx: Don't rely on h1_sl anymore except during H1
header parsing") to designate a response message: HTX_SL_F_IS_RESP.

Unfortunately as it was done in parallel to the mux_h2 support for
the backend, it was never integrated there. It was not used by then
so this remained unnoticed for a while.

However the http_client now uses it, and missing that flag prevents
it from using the H2 mux, so let's properly add it.

There's no point in backporting this far away, but since the http_client
is fully operational in 2.6 it would make sense to backport this fix at
least there to secure the code.
This commit is contained in:
Willy Tarreau 2022-09-02 11:15:37 +02:00
parent a1075209c7
commit d8a44d0b24
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/h2.c
View File

@ -582,7 +582,7 @@ int h2_make_htx_request(struct http_hdr *list, struct htx *htx, unsigned int *ms
*/
static struct htx_sl *h2_prepare_htx_stsline(uint32_t fields, struct ist *phdr, struct htx *htx, unsigned int *msgf)
{
unsigned int status, flags = HTX_SL_F_NONE;
unsigned int status, flags = HTX_SL_F_IS_RESP;
struct htx_sl *sl;
struct ist stat;