RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-02-16 18:46:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: proto_udp/threads: recv() and send() must not be exclusive.

Browse Source 
This is a complement to previous fix for bug #399. The exclusion between
the recv() and send() calls prevents send handlers from being called if
rx readiness is reported. The DNS code can trigger this situations with
threads where the fd_recv_ready() flag disappears between the test in
dgram_fd_handler() and the second test in dns_resolve_recv() while a
thread calls fd_cant_recv(), and this situation can sustain itself for
a while. With 8 threads and an error in the socket queue, placing a
printf on the return statement in dns_resolve_recv() scrolls very fast.

Simply removing the "else" in dgram_fd_handler() addresses the issue.

This fix must be backported as far as 1.6.
This commit is contained in:
Willy Tarreau 2019-12-10 18:12:04 +01:00
parent 1c75995611
commit d7f76a0a50
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/proto_udp.c
View File

@ -26,7 +26,7 @@ void dgram_fd_handler(int fd)
if (fd_recv_ready(fd))
dgram->data->recv(dgram);
else if (fd_send_ready(fd))
if (fd_send_ready(fd))
dgram->data->send(dgram);
return;