RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-04-04 15:19:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: soft-stop: let the first stopper only signal other threads

Browse Source 
When the first thread stops and wakes others up, it's possible some of
them will also start to wake others in parallel. Let's make give this
notification task to the very first one instead since it's enough and
can reduce the amount of needless (though harmless) wakeup calls.
This commit is contained in:
Willy Tarreau 2020-05-13 14:30:25 +02:00
parent d7a6b2f742
commit d645574fd4
1 changed files with 6 additions and 5 deletions

11
src/haproxy.c
View File

@ -2835,11 +2835,12 @@ void run_poll_loop()
int i;
if (stopping) {
_HA_ATOMIC_OR(&stopping_thread_mask, tid_bit);
/* notify all threads that stopping was just set */
for (i = 0; i < global.nbthread; i++)
if (((all_threads_mask & ~stopping_thread_mask) >> i) & 1)
wake_thread(i);
if (_HA_ATOMIC_OR(&stopping_thread_mask, tid_bit) == tid_bit) {
/* notify all threads that stopping was just set */
for (i = 0; i < global.nbthread; i++)
if ((all_threads_mask >> i) & 1)
wake_thread(i);
}
}
/* stop when there's nothing left to do */