RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-02-17 11:06:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: hlua: removing ambiguous lua_pushvalue with 0 index

Browse Source 
In cd341d531, I added a FIXME comment because I noticed a
lua_pushvalue with 0 index, whereas lua doc states that 0 is never
an acceptable index.

After reviewing and testing the hlua_applet_http_send_response() code,
it turns out that this pushvalue is not even needed.
So it's safer to remove it as it could lead to undefined
behavior (since it is not supported by Lua API) and it grows lua stack
by 1 for no reason.

No backport needed.
This commit is contained in:
Aurelien DARRAGON 2022-10-07 11:54:57 +02:00 committed by Christopher Faulet
parent d49b559a15
commit d56bebee7b
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/hlua.c
View File

@ -5377,8 +5377,6 @@ __LJMP static int hlua_applet_http_send_response(lua_State *L)
sl->info.res.status = http_ctx->status;
/* Get the array associated to the field "response" in the object AppletHTTP. */
/* FIXME: according to Lua doc, 0 is considered to be invalid index? */
lua_pushvalue(L, 0);
if (lua_getfield(L, 1, "response") != LUA_TTABLE) {
hlua_pusherror(L, "Lua applet http '%s': AppletHTTP['response'] missing.\n",
luactx->appctx->rule->arg.hlua_rule->fcn->name);