MINOR: connection: don't remove failed handshake flags

It's annoying that handshake handlers remove themselves from the
connection flags when they fail because there is no way to tell
which one fails. So now we only remove them when they succeed.
This commit is contained in:
Willy Tarreau 2012-11-30 15:15:28 +01:00
parent 5a94037644
commit d1b3f0498d
3 changed files with 0 additions and 4 deletions

View File

@ -428,7 +428,6 @@ int conn_recv_proxy(struct connection *conn, int flag)
fail:
conn_sock_stop_both(conn);
conn->flags |= CO_FL_ERROR;
conn->flags &= ~flag;
return 0;
}
@ -574,7 +573,6 @@ int conn_local_send_proxy(struct connection *conn, unsigned int flag)
out_error:
/* Write error on the file descriptor */
conn->flags |= CO_FL_ERROR;
conn->flags &= ~flag;
return 0;
out_wait:

View File

@ -980,7 +980,6 @@ reneg_ok:
/* Fail on all other handshake errors */
conn->flags |= CO_FL_ERROR;
conn->flags &= ~flag;
return 0;
}

View File

@ -485,7 +485,6 @@ int conn_si_send_proxy(struct connection *conn, unsigned int flag)
out_error:
/* Write error on the file descriptor */
conn->flags |= CO_FL_ERROR;
conn->flags &= ~flag;
return 0;
out_wait: