From c9ef9bc9a5caf311ad0de21d559ccee2afd8852d Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Mon, 22 Mar 2021 21:04:50 +0100 Subject: [PATCH] CLEANUP: spoe: use pool_zalloc() instead of pool_alloc+memset Two places used to alloc then zero the area, let's have the allocator do it. --- src/flt_spoe.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/flt_spoe.c b/src/flt_spoe.c index 2d7b3b828..5688ca991 100644 --- a/src/flt_spoe.c +++ b/src/flt_spoe.c @@ -1965,10 +1965,9 @@ spoe_create_appctx(struct spoe_config *conf) if ((appctx = appctx_new(&spoe_applet, tid_bit)) == NULL) goto out_error; - appctx->ctx.spoe.ptr = pool_alloc(pool_head_spoe_appctx); + appctx->ctx.spoe.ptr = pool_zalloc(pool_head_spoe_appctx); if (SPOE_APPCTX(appctx) == NULL) goto out_free_appctx; - memset(appctx->ctx.spoe.ptr, 0, pool_head_spoe_appctx->size); appctx->st0 = SPOE_APPCTX_ST_CONNECT; if ((SPOE_APPCTX(appctx)->task = task_new(tid_bit)) == NULL) @@ -2870,11 +2869,10 @@ spoe_create_context(struct stream *s, struct filter *filter) struct spoe_config *conf = FLT_CONF(filter); struct spoe_context *ctx; - ctx = pool_alloc(pool_head_spoe_ctx); + ctx = pool_zalloc(pool_head_spoe_ctx); if (ctx == NULL) { return NULL; } - memset(ctx, 0, sizeof(*ctx)); ctx->filter = filter; ctx->state = SPOE_CTX_ST_NONE; ctx->status_code = SPOE_CTX_ERR_NONE;