RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-05-16 06:38:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: ssl: make SSL counters atomic

Browse Source 
SSL counters were added with commit d0447a7c3 ("MINOR: ssl: add counters
for ssl sessions") in 2.4, but their updates were not atomic, so it's
likely that under significant loads they are not correct.

This needs to be backported to 2.4.
This commit is contained in:
Willy Tarreau 2021-11-22 17:46:13 +01:00
parent 0a1e1cb555
commit c5e7cf9e69
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/ssl_sock.c
View File

@ -5844,13 +5844,13 @@ reneg_ok:
}
if (counters) {
++counters->sess;
++counters_px->sess;
HA_ATOMIC_INC(&counters->sess);
HA_ATOMIC_INC(&counters_px->sess);
}
}
else if (counters) {
++counters->reused_sess;
++counters_px->reused_sess;
HA_ATOMIC_INC(&counters->reused_sess);
HA_ATOMIC_INC(&counters_px->reused_sess);
}
/* The connection is now established at both layers, it's time to leave */
@ -5876,8 +5876,8 @@ reneg_ok:
}
if (counters) {
++counters->failed_handshake;
++counters_px->failed_handshake;
HA_ATOMIC_INC(&counters->failed_handshake);
HA_ATOMIC_INC(&counters_px->failed_handshake);
}
/* Fail on all other handshake errors */