RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-02-28 00:20:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: lua: initialize sample before using it

Browse Source 
Memset the sample before using it through hlua_lua2smp. This function is
ORing the smp.flags, so this field need to be cleared before its use.
This was reported by a coverity warning.

Fixes the github issue #929.
This bug can be backported up to 1.8.
This commit is contained in:
Amaury Denoyelle 2020-10-29 17:21:20 +01:00 committed by Christopher Faulet
parent e6ba7915eb
commit bc0af6a199
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/hlua.c
View File

@ -3505,6 +3505,7 @@ __LJMP static int hlua_run_sample_conv(lua_State *L)
}
/* Initialise the sample. */
memset(&smp, 0, sizeof(smp));
if (!hlua_lua2smp(L, 2, &smp)) {
hlua_pusherror(L, "error in the input argument");
goto error;
@ -3649,6 +3650,7 @@ __LJMP static int hlua_applet_tcp_set_var(lua_State *L)
s = appctx->htxn.s;
/* Converts the third argument in a sample. */
memset(&smp, 0, sizeof(smp));
hlua_lua2smp(L, 3, &smp);
/* Store the sample in a variable. */
@ -4133,6 +4135,7 @@ __LJMP static int hlua_applet_http_set_var(lua_State *L)
s = appctx->htxn.s;
/* Converts the third argument in a sample. */
memset(&smp, 0, sizeof(smp));
hlua_lua2smp(L, 3, &smp);
/* Store the sample in a variable. */
@ -5225,6 +5228,7 @@ __LJMP static int hlua_set_var(lua_State *L)
name = MAY_LJMP(luaL_checklstring(L, 2, &len));
/* Converts the third argument in a sample. */
memset(&smp, 0, sizeof(smp));
hlua_lua2smp(L, 3, &smp);
/* Store the sample in a variable. */