RepoMirrors
/
haproxy
mirror of http://git.haproxy.org/git/haproxy.git/
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: promex: Wait to have the request before sending the response 

It is similar to the previous fix about the stats applet ("BUG/MEDIUM:
cache/stats: Wait to have the request before sending the response").
However, for promex, there is no crash and no obvious issue. But it depends
on the filter. Indeed, the request is used by promex, independantly if it
was considered as forwarded or not. So if it is modified by the filter,
modification are just ignored.

Same bug, same fix. We now wait the request was forwarded before processing
it and produce the response.
This commit is contained in:
Christopher Faulet 2024-09-16 22:29:24 +02:00
parent afc50f2445
commit bb2a2bc5f2
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
addons/promex/service-prometheus.c
View File

@ -2105,6 +2105,10 @@ static void promex_appctx_handle_io(struct appctx *appctx)
switch (appctx->st0) { switch (appctx->st0) {
case PROMEX_ST_INIT: case PROMEX_ST_INIT:
if (!co_data(req)) {
applet_need_more_data(appctx);
goto out;
}
ret = promex_parse_uri(appctx, sc); ret = promex_parse_uri(appctx, sc);
if (ret <= 0) { if (ret <= 0) {
if (ret == -1) if (ret == -1)