RepoMirrors
/
haproxy
mirror of http://git.haproxy.org/git/haproxy.git/
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MINOR: threads: Be sure to remove threads from all_threads_mask on exit 

When HAProxy is started with several threads, Each running thread holds a bit in
the bitfiled all_threads_mask. This bitfield is used here and there to check
which threads are registered to take part in a specific processing. So when a
thread exits, it seems normal to remove it from all_threads_mask.

No direct impact could be identified with this right now but it would
be better to backport it to 1.8 as a preventive measure to avoid complex
situations like the one in previous bug.
This commit is contained in:
Christopher Faulet 2018-06-21 09:57:39 +02:00 committed by Willy Tarreau
parent d8fd2af882
commit ba86c6c25b
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/haproxy.c
View File

@ -2473,6 +2473,8 @@ static void *run_thread_poll_loop(void *data)
list_for_each_entry(ptdf, &per_thread_deinit_list, list) list_for_each_entry(ptdf, &per_thread_deinit_list, list)
ptdf->fct(); ptdf->fct();
HA_ATOMIC_AND(&all_threads_mask, ~tid_bit);
#ifdef USE_THREAD #ifdef USE_THREAD
if (tid > 0) if (tid > 0)
pthread_exit(NULL); pthread_exit(NULL);