From b789cef91f5ac6123b130f5474b44fb7c57106ae Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Mon, 1 Jul 2024 10:33:03 +0200 Subject: [PATCH] BUG/MINOR: promex: Remove Help prefix repeated twice for each metric When the support for modules was added, the function producing the #HELP line of each metric was refactored. Since then, the prefix "#HELP " is printed twice because a code block was not removed. It is now fixed. This patch must be backported to 3.0. --- addons/promex/service-prometheus.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/addons/promex/service-prometheus.c b/addons/promex/service-prometheus.c index 4e0bc68e1..99aa46482 100644 --- a/addons/promex/service-prometheus.c +++ b/addons/promex/service-prometheus.c @@ -438,11 +438,6 @@ static int promex_dump_ts_header(const struct ist name, const struct ist desc, e t = ist("gauge"); } - if (istcat(out, ist("# HELP "), max) == -1 || - istcat(out, name, max) == -1 || - istcat(out, ist(" "), max) == -1) - goto full; - if (istcat(out, ist("# HELP "), max) == -1 || istcat(out, name, max) == -1 || istcat(out, ist(" "), max) == -1 ||