RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-02-01 19:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: resolvers: Don't overwrite the error for invalid query domain name

Browse Source 
When a response is validated, the query domain name is checked to be sure it
is the same than the one requested. When an error is reported, the wrong
goto label was used. Thus, the error was lost. Instead of
RSLV_RESP_WRONG_NAME, RSLV_RESP_INVALID was reported.

This bug was introduced by the commit c1699f8c1 ("MEDIUM: resolvers: No
longer store query items in a list into the response").

This patch should fix the issue #1473. No backport is needed.
This commit is contained in:
Christopher Faulet 2021-12-02 10:05:02 +01:00
parent 02c893332b
commit af93d2fd70
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/resolvers.c
View File

@ -1004,7 +1004,7 @@ static int resolv_validate_dns_response(unsigned char *resp, unsigned char *bufe
if (len != resolution->hostname_dn_len ||
memcmp(query->name, resolution->hostname_dn, resolution->hostname_dn_len) != 0) {
cause = RSLV_RESP_WRONG_NAME;
goto invalid_resp;
goto return_error;
}
reader += offset;