From a80b22eac4f4893cb603650ce813024d6689f802 Mon Sep 17 00:00:00 2001 From: William Lallemand Date: Thu, 22 Dec 2022 14:49:43 +0100 Subject: [PATCH] MINOR: httpclient: don't add body when istlen is empty Don't try to create a request with a body in httpclient_req_gen() if the payload ist has a ptr but no len. Sometimes people have their httpclient stuck because they use an ist with a data ptr but no len. Check the len so this mistake doesn't block the client. --- src/http_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/http_client.c b/src/http_client.c index b33664064..bd398237e 100644 --- a/src/http_client.c +++ b/src/http_client.c @@ -343,7 +343,7 @@ int httpclient_req_gen(struct httpclient *hc, const struct ist url, enum http_me if (!htx_add_endof(htx, HTX_BLK_EOH)) goto error; - if (isttest(payload)) { + if (isttest(payload) && istlen(payload)) { /* add the payload if it can feat in the buffer, no need to set * the Content-Length, the data will be sent chunked */ if (!htx_add_data_atonce(htx, payload))