RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-01-31 10:31:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: spoe: Return an error if nothing is encoded for fragmented messages

Browse Source 
If the maximum frame size is very small with a large message or argument name,
it is possible to be unable to encode anything. In such case, it is important to
stop processing returning an error otherwise we will retry in loop to encode the
message, failing each time because of the too small frame size.

This patch must be backported to 1.9 and 1.8.
This commit is contained in:
Christopher Faulet 2019-04-10 14:21:51 +02:00
parent 3e86cec05e
commit a715ea82ea
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/flt_spoe.c
View File

@ -2287,7 +2287,9 @@ spoe_encode_messages(struct stream *s, struct spoe_context *ctx,
return 1;
too_big:
if (!(agent->flags & SPOE_FL_SND_FRAGMENTATION)) {
/* Return an error if fragmentation is unsupported or if nothing has
* been encoded because its too big and not splittable. */
if (!(agent->flags & SPOE_FL_SND_FRAGMENTATION) || p == b_head(&ctx->buffer)) {
ctx->status_code = SPOE_CTX_ERR_TOO_BIG;
return -1;
}