RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-04-01 22:48:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MAJOR: cookie prefix doesn't support cookie-less servers

Browse Source 
Commit 827aee91 merged in 1.5-dev5 introduced a regression causing
the srv pointer to be tested twice instead of srv then srv->cookie.
The result is that if a server has no cookie in prefix mode, haproxy
will crash when trying to modify it.

Such a config is very unlikely to happen, except maybe with a backup
server, which would cause haproxy to die with the last server in the
farm.

No backport is needed, only 1.5-dev was affected.
This commit is contained in:
Willy Tarreau 2012-06-06 16:07:00 +02:00
parent 02c7c14ae7
commit a05903174f
1 changed files with 1 additions and 1 deletions

2
src/proto_http.c
View File

@ -6907,7 +6907,7 @@ void manage_server_side_cookies(struct session *t, struct buffer *res)
txn->flags &= ~TX_SCK_MASK;
txn->flags |= TX_SCK_REPLACED;
}
else if (srv && srv && (t->be->ck_opts & PR_CK_PFX)) {
else if (srv && srv->cookie && (t->be->ck_opts & PR_CK_PFX)) {
/* insert the cookie name associated with this server
* before existing cookie, and insert a delimiter between them..
*/