RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-03-06 19:38:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: log: fix risk of null deref on error path

Browse Source 
Previous commit ae32ac74db ("BUG/MINOR: log: fix memory leak on logsrv
parse error") addressed one issue and introduced another one, the logsrv
pointer may also be null at the end of the function so we must test it
before deciding to dereference it.

This should be backported along with the patch above to 2.2.
This commit is contained in:
Willy Tarreau 2020-10-27 10:35:32 +01:00
parent ae32ac74db
commit a0133fcf35
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/log.c
View File

@ -1039,7 +1039,8 @@ int parse_logsrv(char **args, struct list *logsrvs, int do_del, char **err)
error:
free(smp_rgs);
free(logsrv->ring_name);
if (logsrv)
free(logsrv->ring_name);
free(logsrv);
return 0;
}