From 9f0c984cf50fee3a2282993b573be2f049efe5ab Mon Sep 17 00:00:00 2001 From: Gilchrist Dadaglo Date: Mon, 24 Aug 2020 19:21:32 +0000 Subject: [PATCH] BUG/MINOR: contrib/spoa-server: Ensure ip address references are freed IP addresses references passed in argument for ps_python are not freed after they have been used. Leading to a small chance of mem leak if a lot of ip addresses are passed around This patch must be backported as far as 2.0. --- contrib/spoa_server/ps_python.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/contrib/spoa_server/ps_python.c b/contrib/spoa_server/ps_python.c index 3ad64a7a7c..427ef18ee0 100644 --- a/contrib/spoa_server/ps_python.c +++ b/contrib/spoa_server/ps_python.c @@ -244,6 +244,8 @@ static PyObject *ps_python_set_var_ipv4(PyObject *self, PyObject *args) PyErr_SetString(spoa_error, "No space left available"); return NULL; } + /* Once we set the IP value in the worker, we don't need it anymore... */ + Py_XDECREF(value); return Py_None; } @@ -279,6 +281,8 @@ static PyObject *ps_python_set_var_ipv6(PyObject *self, PyObject *args) PyErr_SetString(spoa_error, "No space left available"); return NULL; } + /* Once we set the IP value in the worker, we don't need it anymore... */ + Py_XDECREF(value); return Py_None; }