From 99f47377c86987da550ac1ea393eda72fdc7acd8 Mon Sep 17 00:00:00 2001 From: Tim Duesterhus Date: Tue, 15 Mar 2022 13:11:05 +0100 Subject: [PATCH] DEV: coccinelle: Fix incorrect replacement in ist.cocci We must not use `ist2()` if the value of `i.len` is derived from the value of `i.ptr`: i.ptr = "foo"; i.len = strlen(i.ptr); --- dev/coccinelle/ist.cocci | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dev/coccinelle/ist.cocci b/dev/coccinelle/ist.cocci index 4945141b2..ea13d39d2 100644 --- a/dev/coccinelle/ist.cocci +++ b/dev/coccinelle/ist.cocci @@ -3,9 +3,14 @@ struct ist i; expression p, l; @@ +( + i.ptr = p; + i.len = strlen(i.ptr); +| - i.ptr = p; - i.len = l; + i = ist2(p, l); +) @@ @@