RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-01-22 21:43:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: tcp-rules: Return an internal error if an action yields on a final eval

Browse Source 
On a final evaluation of a tcp-request or tcp-response content ruleset, it is
forbidden for an action to yield. To quickly identify bugs an internal error is
now returned if it happens and a warning log message is emitted.
This commit is contained in:
Christopher Faulet 2020-07-28 11:30:19 +02:00
parent 498c483009
commit 99aaca99b5
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/tcp_rules.c
View File

@ -161,6 +161,12 @@ resume_execution:
goto end; goto end;
case ACT_RET_YIELD: case ACT_RET_YIELD:
s->current_rule = rule; s->current_rule = rule;
if (partial & SMP_OPT_FINAL) {
send_log(s->be, LOG_WARNING,
"Internal error: yield not allowed if the inspect-delay expired "
"for the tcp-request content actions.");
goto internal;
}
goto missing_data; goto missing_data;
case ACT_RET_DENY: case ACT_RET_DENY:
goto deny; goto deny;
@ -313,6 +319,12 @@ resume_execution:
goto end; goto end;
case ACT_RET_YIELD: case ACT_RET_YIELD:
s->current_rule = rule; s->current_rule = rule;
if (partial & SMP_OPT_FINAL) {
send_log(s->be, LOG_WARNING,
"Internal error: yield not allowed if the inspect-delay expired "
"for the tcp-response content actions.");
goto internal;
}
goto missing_data; goto missing_data;
case ACT_RET_DENY: case ACT_RET_DENY:
goto deny; goto deny;