RepoMirrors
/
haproxy
mirror of http://git.haproxy.org/git/haproxy.git/
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: quic: fix datagram dropping on queueing failed 

After reading a datagram, it is enqueud for the thread attached to the
DCID. This is done via quic_lstnr_dgram_dispatch() function. If this
step fails, we remove the datagram from the buffer of quic_receiver_buf.

This step is faulty because we use b_del() instead of b_sub(). If
quic_receiver_buf was not empty, we will remove content from another
datagram while leaving the content of the last read datagram. This
probably produces valid datagram dropping and may even result in crash.

As stated, this bug can only happen if qc_lstnr_dgram_dispatch() fails
which happen on two occaions :
* on quic_dgram allocation failure, which should be pretty rare
* on datagram labelled as invalid for QUIC protocol. This may happen
  more frequently depending on the network conditions. Thus, this bug
  has been labelled as a medium one.

This should be backported up to 2.6.
This commit is contained in:
Amaury Denoyelle 2022-11-24 15:24:38 +01:00
parent 6c72fa3d18
commit 9875f024ba
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/quic_sock.c
View File

@ -436,7 +436,7 @@ void quic_sock_fd_iocb(int fd)
if (!quic_lstnr_dgram_dispatch(dgram_buf, ret, l, &saddr, &daddr, if (!quic_lstnr_dgram_dispatch(dgram_buf, ret, l, &saddr, &daddr,
new_dgram, &rxbuf->dgram_list)) { new_dgram, &rxbuf->dgram_list)) {
/* If wrong, consume this datagram */ /* If wrong, consume this datagram */
b_del(buf, ret); b_sub(buf, ret);
} }
new_dgram = NULL; new_dgram = NULL;
if (--max_dgrams > 0) if (--max_dgrams > 0)