MINOR: task: only check TASK_WOKEN_ANY to decide to requeue a task
After processing a task, its RUNNING bit is cleared and at the same time we check for other bits to decide whether to requeue the task or not. It happens that we only want to check the TASK_WOKEN_* bits, because : - TASK_RUNNING was just cleared - TASK_GLOBAL and TASK_QUEUE cannot be set yet as the task was running, preventing it from being requeued It's important not to catch yet undefined flags there because it would prevent addition of new task flags. This also shows more clearly that waking a task up with flags 0 is not something safe to do as the task will not be woken up if it's already running.
This commit is contained in:
parent
d5b464bfee
commit
8fe4253bf6
|
@ -482,7 +482,7 @@ void process_runnable_tasks()
|
||||||
}
|
}
|
||||||
|
|
||||||
state = _HA_ATOMIC_AND(&t->state, ~TASK_RUNNING);
|
state = _HA_ATOMIC_AND(&t->state, ~TASK_RUNNING);
|
||||||
if (state)
|
if (state & TASK_WOKEN_ANY)
|
||||||
task_wakeup(t, 0);
|
task_wakeup(t, 0);
|
||||||
else
|
else
|
||||||
task_queue(t);
|
task_queue(t);
|
||||||
|
|
Loading…
Reference in New Issue