BUG/MINOR: cache: Cache response even if request has "no-cache" directive

Since commit cc9bf2e5f "MEDIUM: cache: Change caching conditions"
responses that do not have an explicit expiration time are not cached
anymore. But this mechanism wrongly used the TX_CACHE_IGNORE flag
instead of the TX_CACHEABLE one. The effect this had is that a cacheable
response that corresponded to a request having a "Cache-Control:
no-cache" for instance would not be cached.
Contrary to what was said in the other commit message, the "checkcache"
option should not be impacted by the use of the TX_CACHEABLE flag
instead of the TX_CACHE_IGNORE one. The response is indeed considered as
not cacheable if it has no expiration time, regardless of the presence
of a cookie in the response.

This should fix GitHub issue #2048.
This patch can be backported up to branch 2.4.
This commit is contained in:
Remi Tricot-Le Breton 2023-02-21 11:47:17 +01:00 committed by Willy Tarreau
parent d4c0be6b20
commit 879debeecb
4 changed files with 35 additions and 3 deletions

View File

@ -61,7 +61,7 @@
/* cacheability management, bits values 0x1000 to 0x3000 (0-3 shift 12) */
#define TX_CACHEABLE 0x00001000 /* at least part of the response is cacheable */
#define TX_CACHE_COOK 0x00002000 /* a cookie in the response is cacheable */
#define TX_CACHE_IGNORE 0x00004000 /* do not retrieve object from cache, or avoid caching response */
#define TX_CACHE_IGNORE 0x00004000 /* do not retrieve object from cache */
#define TX_CACHE_SHIFT 12 /* bit shift */
#define TX_CON_WANT_TUN 0x00008000 /* Will be a tunnel (CONNECT or 101-Switching-Protocol) */

View File

@ -67,6 +67,18 @@ server s1 {
txresp -hdr "Cache-Control: max-age=500" \
-hdr "Age: 100" -bodylen 140
# "Control-Cache: no-cache" on client request but still stored in cache
rxreq
expect req.url == "/nocache"
txresp -hdr "Cache-Control: max-age=500" \
-hdr "Age: 100" -bodylen 140
rxreq
expect req.url == "/nocache"
txresp -hdr "Cache-Control: max-age=500" \
-hdr "Age: 100" -bodylen 140
} -start
server s2 {
@ -221,4 +233,24 @@ client c1 -connect ${h1_fe_sock} {
expect resp.bodylen == 140
expect resp.http.X-Cache-Hit == 1
# Cache-Control: no-cache
txreq -url "/nocache" -hdr "Cache-Control: no-cache"
rxresp
expect resp.status == 200
expect resp.bodylen == 140
expect resp.http.X-Cache-Hit == 0
txreq -url "/nocache" -hdr "Cache-Control: no-cache"
rxresp
expect resp.status == 200
expect resp.bodylen == 140
expect resp.http.X-Cache-Hit == 0
txreq -url "/nocache"
rxresp
expect resp.status == 200
expect resp.bodylen == 140
expect resp.http.X-Cache-Hit == 1
} -run

View File

@ -1101,7 +1101,7 @@ enum act_return http_action_store_cache(struct act_rule *rule, struct proxy *px,
http_check_response_for_cacheability(s, &s->res);
if (!(txn->flags & TX_CACHEABLE) || !(txn->flags & TX_CACHE_COOK) || (txn->flags & TX_CACHE_IGNORE))
if (!(txn->flags & TX_CACHEABLE) || !(txn->flags & TX_CACHE_COOK))
goto out;
shctx_lock(shctx);

View File

@ -3772,7 +3772,7 @@ void http_check_response_for_cacheability(struct stream *s, struct channel *res)
/* We won't store an entry that has neither a cache validator nor an
* explicit expiration time, as suggested in RFC 7234#3. */
if (!has_freshness_info && !has_validator)
txn->flags |= TX_CACHE_IGNORE;
txn->flags &= ~TX_CACHEABLE;
}
/*