BUG: errors: remove printf positional args for user messages context

Change the algorithm for the generation of the user messages context
prefix. Remove the dubious API relying on optional printf positional
arguments. This may be non portable, and in fact the CI glibc crashes
with the following error when some arguments are not present in the
format string :

"invalid %N$ use detected".

Now, a fixed buffer attached to the context instance is allocated once
for the program lifetime. Then call repeatedly snprintf with the
optional arguments of context if present to build the context string.
The buffer is deallocated via a per-thread free handler.

This does not need to be backported.

include/haproxy/errors.h

@@ -25,6 +25,8 @@
 #include <stdarg.h>
 #include <stdio.h>
 
+#include <haproxy/buf-t.h>
+
 /* These flags may be used in various functions which are called from within
  * loops (eg: to start all listeners from all proxies). They provide enough
  * information to let the caller decide what to do. ERR_WARN and ERR_ALERT
@@ -67,6 +69,8 @@ const char *usermsgs_str(void);
 /************ Error reporting functions ***********/
 
 struct usermsgs_ctx {
+	struct buffer str;
+
 	const char *prefix;  /* prefix of every output */
 	const char *file;    /* related filename for config parsing */
 	int line;            /* related line number for config parsing */

src/errors.c

@@ -25,7 +25,8 @@ static THREAD_LOCAL struct buffer usermsgs_buf = BUF_NULL;
 
 /* A thread local context used for stderr output via ha_alert/warning/notice/diag.
  */
-static THREAD_LOCAL struct usermsgs_ctx usermsgs_ctx = { };
+#define USERMSGS_CTX_BUFSIZE   PATH_MAX
+static THREAD_LOCAL struct usermsgs_ctx usermsgs_ctx = { .str = BUF_NULL, };
 
 /* Put msg in usermsgs_buf.
  *
@@ -118,35 +119,49 @@ void reset_usermsgs_ctx(void)
 	usermsgs_ctx.obj = NULL;
 }
 
-static void generate_usermsgs_ctx_str(char **str)
+static void generate_usermsgs_ctx_str(void)
 {
-	const struct usermsgs_ctx *ctx = &usermsgs_ctx;
+	struct usermsgs_ctx *ctx = &usermsgs_ctx;
-	const char prefix_fmt[] = "%1$s : ";
+	void *area;
-	const char file_line_fmt[] = "[%2$s:%3$d] : ";
+	int ret;
-	const char obj_line_fmt[] = "%4$s/%5$s";
 
-	/* fmt must be big enough to contains the full format string before
+	if (unlikely(b_is_null(&ctx->str))) {
-	 * memprintf */
+		area = calloc(USERMSGS_CTX_BUFSIZE, sizeof(char));
-	char fmt[56];
+		if (area)
+			ctx->str = b_make(area, USERMSGS_CTX_BUFSIZE, 0, 0);
+	}
 
-	switch (obj_type(ctx->obj)) {
+	if (likely(!b_is_null(&ctx->str))) {
-	case OBJ_TYPE_SERVER:
+		b_reset(&ctx->str);
-		sprintf(fmt, "%s%s'server %s' : ",
-		        ctx->prefix ? prefix_fmt : "",
-		        ctx->file ? file_line_fmt : "",
-		        obj_line_fmt);
-		memprintf(str, fmt, ctx->prefix, ctx->file, ctx->line,
-		          __objt_server(ctx->obj)->proxy->id,
-		          __objt_server(ctx->obj)->id);
-		break;
 
-	case OBJ_TYPE_NONE:
+		if (ctx->prefix) {
-	default:
+			ret = snprintf(b_tail(&ctx->str), b_room(&ctx->str),
-		sprintf(fmt, "%s%s",
+			               "%s : ", ctx->prefix);
-		        ctx->prefix ? prefix_fmt : "",
+			b_add(&ctx->str, MIN(ret, b_room(&ctx->str)));
-		        ctx->file ? file_line_fmt : "");
+		}
-		memprintf(str, fmt, ctx->prefix, ctx->file, ctx->line);
+
-		break;
+		if (ctx->file) {
+			ret = snprintf(b_tail(&ctx->str), b_room(&ctx->str),
+			               "[%s:%d] : ", ctx->file, ctx->line);
+			b_add(&ctx->str, MIN(ret, b_room(&ctx->str)));
+		}
+
+		switch (obj_type(ctx->obj)) {
+		case OBJ_TYPE_SERVER:
+			ret = snprintf(b_tail(&ctx->str), b_room(&ctx->str),
+			               "'server %s/%s' : ",
+			               __objt_server(ctx->obj)->proxy->id,
+			               __objt_server(ctx->obj)->id);
+			b_add(&ctx->str, MIN(ret, b_room(&ctx->str)));
+			break;
+
+		case OBJ_TYPE_NONE:
+		default:
+			break;
+		}
+
+		if (!b_data(&ctx->str))
+			snprintf(b_tail(&ctx->str), b_room(&ctx->str), "%s", "");
 	}
 }
 
@@ -175,11 +190,12 @@ static void print_message(int use_usermsgs_ctx, const char *label, const char *f
 		msg_ist.len--;
 
 	if (use_usermsgs_ctx) {
-		generate_usermsgs_ctx_str(&parsing_str);
+		generate_usermsgs_ctx_str();
+		parsing_str = b_head(&usermsgs_ctx.str);
 		reset_usermsgs_ctx();
 	}
 	else {
-		memprintf(&parsing_str, "%s", "");
+		parsing_str = "";
 	}
 
 	if (global.mode & MODE_STARTING) {
@@ -204,7 +220,6 @@ static void print_message(int use_usermsgs_ctx, const char *label, const char *f
 	fflush(stderr);
 
 	free(head);
-	free(parsing_str);
 	free(msg);
 }
 
@@ -357,6 +372,7 @@ static void deinit_errors_buffers()
 {
 	ring_free(_HA_ATOMIC_XCHG(&startup_logs, NULL));
 	ha_free(&usermsgs_buf.area);
+	ha_free(&usermsgs_ctx.str.area);
 }
 
 REGISTER_PER_THREAD_FREE(deinit_errors_buffers);