RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2024-12-24 05:32:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: h1-htx: Don't state interim responses are bodyless

Browse Source 
Interim responses are by definition bodyless. But we must not set the
corresponding HTX start-line flag, beecause the start-line of the final
response is still expected. Setting the flag above too early may lead the
multiplexer on the sending side to consider the message is finished after
the headers of the interim message.

It happens with the H2 multiplexer on frontend side if a "100-Continue" is
received from the server. The interim response is sent and
HTX_SL_F_BODYLESS_RESP flag is evaluated. Then, the headers of the final
response are sent with ES flag, because HTX_SL_F_BODYLESS_RESP flag was seen
too early, leading to a protocol error if the response has a body.

Thanks to grembo for this analysis.

This patch should fix the issue #2587. It must be backported as far as 2.9.
This commit is contained in:
Christopher Faulet 2024-06-03 17:46:16 +02:00
parent 1ef6cdcd26
commit 7c84ee71f7
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/h1_htx.c
View File

@ -295,7 +295,8 @@ static int h1_postparse_res_hdrs(struct h1m *h1m, union h1_sl *h1sl, struct htx
/* Responses known to have no body. */ /* Responses known to have no body. */
h1m->flags |= H1_MF_XFER_LEN; h1m->flags |= H1_MF_XFER_LEN;
h1m->curr_len = h1m->body_len = 0; h1m->curr_len = h1m->body_len = 0;
flags |= HTX_SL_F_BODYLESS_RESP; if (code >= 200)
flags |= HTX_SL_F_BODYLESS_RESP;
} }
else if (h1m->flags & (H1_MF_CLEN|H1_MF_CHNK)) { else if (h1m->flags & (H1_MF_CLEN|H1_MF_CHNK)) {
/* Responses with a known body length. */ /* Responses with a known body length. */