RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-02-18 11:47:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: quic: Avoid BUG_ON() on ->on_pkt_lost() BBR callback call

Browse Source 
The per-packet delivery rate sample is applied to ack-eliciting packet only
calling ->drs_on_transmit() BBR callback. So, ->on_pkt_lost() which inspects the
delivery rate sampling information during packet loss detection must not be
called for non ack-eliciting packet. If not, it would be facing with non
initialized variables with big chance to trigger a BUG_ON().

As BBR is implemented in the current developement version, there is
no need to backport this patch.
This commit is contained in:
Frederic Lecaille 2024-11-22 15:40:05 +01:00
parent b30639848e
commit 7472990f86
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/quic_loss.c
View File

@ -216,7 +216,9 @@ void qc_packet_loss_lookup(struct quic_pktns *pktns, struct quic_conn *qc,
if (tick_is_le(loss_time_limit, now_ms) || reordered) {
struct quic_cc *cc = &qc->path->cc;
if (cc->algo->on_pkt_lost)
/* Delivery rate sampling is applied to ack-eliciting packet only. */
if ((pkt->flags & QUIC_FL_TX_PACKET_ACK_ELICITING) &&
cc->algo->on_pkt_lost)
cc->algo->on_pkt_lost(cc, pkt, pkt->rs.lost);
eb64_delete(&pkt->pn_node);
LIST_APPEND(lost_pkts, &pkt->list);