RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-04-01 22:48:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: stats: do not call cli_release_handler 3 times

Browse Source 
If an error happens during a dump on the CLI, an explicit call to
cli_release_handler() is performed. This is not needed anymore since
we introduced ->release() in the applet which is called upon error.
Let's remove this confusing call which can even be risky in some
situations.
This commit is contained in:
Willy Tarreau 2015-09-25 19:21:19 +02:00
parent eca572fe7f
commit 68c00c7185
1 changed files with 1 additions and 7 deletions

8
src/dumpstats.c
View File

@ -2482,13 +2482,7 @@ static void cli_io_handler(struct appctx *appctx)
bo_skip(si_oc(si), reql);
req->flags |= CF_READ_DONTWAIT; /* we plan to read small requests */
}
else { /* output functions: first check if the output buffer is closed then abort */
if (res->flags & (CF_SHUTR_NOW|CF_SHUTR)) {
cli_release_handler(appctx);
appctx->st0 = STAT_CLI_END;
continue;
}
else { /* output functions */
switch (appctx->st0) {
case STAT_CLI_PRINT:
if (bi_putstr(si_ic(si), appctx->ctx.cli.msg) != -1)