RepoMirrors
/
haproxy
mirror of http://git.haproxy.org/git/haproxy.git/
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: spoe: Be sure to be able to quickly close IDLE applets on soft-stop 

On soft-stop, we try, as far as possible, to process all pending messages
before closing SPOE applets. However, in sync mode, when an applets waiting
for a response receives the ACK frame, it is switched to IDLE state without
checking if it may be closed. In this case, we will wait the idle timeout
before closing de applet, delaying the soft-stop.

To reduce this delay, on soft-stop, IDLE applets are woken up. On the next
wakeup, the applet will try to process pending messages or will be
closed.

This patch should be backported to all stable versions.
This commit is contained in:
Christopher Faulet 2024-03-14 10:49:01 +01:00
parent 3c066b1e34
commit 6547b14292
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/flt_spoe.c
View File

@ -2001,7 +2001,9 @@ spoe_handle_appctx(struct appctx *appctx)
return; return;
} }
out: out:
if (SPOE_APPCTX(appctx)->task->expire != TICK_ETERNITY) if (stopping && appctx->st0 == SPOE_APPCTX_ST_IDLE)
task_wakeup(SPOE_APPCTX(appctx)->task, TASK_WOKEN_MSG);
else if (SPOE_APPCTX(appctx)->task->expire != TICK_ETERNITY)
task_queue(SPOE_APPCTX(appctx)->task); task_queue(SPOE_APPCTX(appctx)->task);
} }