RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2024-12-22 20:32:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

CONTRIB: da: fix memory leak in dummy function da_atlas_open()

Browse Source 
The dummy function takes care of doing a bit of work using a malloc()
to avoid returning a constant but it doesn't free the tested pointer,
which coverity noticed in issue #741. Let's free it before testing it
for the return value.

This may be backported but is not important since this code is only
present to allow to build the device detection code and not to actually
run it.
This commit is contained in:
Willy Tarreau 2020-07-12 09:12:07 +02:00
parent 950954f5f7
commit 62fd12149f
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
contrib/deviceatlas/dac.c
View File

@ -63,8 +63,9 @@ da_atlas_compile(void *ctx, da_read_fn readfn, da_setpos_fn rewind, void **ptr,
da_status_t
da_atlas_open(da_atlas_t *atlas, da_property_decl_t *extraprops, const void *ptr, size_t len)
{
ptr = malloc(len);
return ptr ? DA_OK : DA_NOMEM;
void *ptr2 = malloc(len);
free(ptr2);
return ptr2 ? DA_OK : DA_NOMEM;
}
void