RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-04-10 11:11:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

OPTIM: stream_interface: disable reading when CF_READ_DONTWAIT is set

Browse Source 
CF_READ_DONTWAIT was designed to avoid getting an EAGAIN upon recv() when
very few data are expected. It prevents the reader from looping over
recv(). Unfortunately with speculative I/O, it is very common that the
same event has the time to be called twice before the task handles the
data and disables the recv(). This is because not all tasks are always
processed at once.

Instead of leaving the buffer free-wheeling and doing an EAGAIN, we
disable reading as soon as the first recv() succeeds. This way we're
sure that only the next wakeup of the task will re-enable it if needed.

Doing so has totally removed the EAGAIN we were seeing till now (30% of
recv).
This commit is contained in:
Willy Tarreau 2012-11-09 18:27:26 +01:00
parent 037d2c1f8f
commit 5fddab0a56
1 changed files with 3 additions and 1 deletions

4
src/stream_interface.c
View File

@ -1086,8 +1086,10 @@ static void si_conn_recv_cb(struct connection *conn)
break;
}
if ((chn->flags & CF_READ_DONTWAIT) || --read_poll <= 0)
if ((chn->flags & CF_READ_DONTWAIT) || --read_poll <= 0) {
conn_data_stop_recv(conn);
break;
}
/* if too many bytes were missing from last read, it means that
* it's pointless trying to read again because the system does