RepoMirrors
/
haproxy
mirror of http://git.haproxy.org/git/haproxy.git/
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: sc_strm/applet: Wake applet after a successfull synchronous send 

On a synchronous send from the stream to an applet, if some data were sent,
we must take care to wake the applet up. It is important because if
everything was sent at this stage, there is no other chance to wake the
applet up, mainly because SE_FL_WAIT_DATA flag is set on the applet's sedesc
in sc_update_tx() at the end of process_stream(). This flag prevent any
wakeup of the applet for a send event.

It is not necessary for a mux because the mux stream is called when a
syncrhonous send from the stream is performed. So it is reponsible to wake
the mux connection if necessary.

This patch must be backport to 3.0.
This commit is contained in:
Christopher Faulet 2024-09-16 19:12:02 +02:00
parent 655124f5cc
commit 5fc12b0afd
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
include/haproxy/sc_strm.h
View File

@ -348,8 +348,15 @@ static inline void sc_sync_send(struct stconn *sc)
{ {
if (sc_ep_test(sc, SE_FL_T_MUX)) if (sc_ep_test(sc, SE_FL_T_MUX))
sc_conn_sync_send(sc); sc_conn_sync_send(sc);
else if (sc_ep_test(sc, SE_FL_T_APPLET)) else if (sc_ep_test(sc, SE_FL_T_APPLET)) {
sc_applet_sync_send(sc); sc_applet_sync_send(sc);
if (sc_oc(sc)->flags & CF_WRITE_EVENT) {
/* Data was send, wake the applet up. It is safe to do so becasuse sc_applet_sync_send()
* removes CF_WRITE_EVENT flag from the channel before trying to send data to the applet.
*/
task_wakeup(__sc_appctx(sc)->t, TASK_WOKEN_OTHER);
}
}
} }
/* Combines both sc_update_rx() and sc_update_tx() at once */ /* Combines both sc_update_rx() and sc_update_tx() at once */