RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-05-06 01:37:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: lua: use strlcpy2() not strncpy() to copy sample keywords

Browse Source 
The lua initialization code which creates the Lua mapping of all converters
and sample fetch keywords makes use of strncpy(), and as such can take ages
to start with large values of tune.bufsize because it spends its time zeroing
gigabytes of memory for nothing. A test performed with an extreme value of
16 MB takes roughly 4 seconds, so it's possible that some users with huge
1 MB buffers (e.g. for payload analysis) notice a small startup latency.
However this does not affect config checks since the Lua stack is not yet
started. Let's replace this with strlcpy2().

This should be backported to all supported versions.
This commit is contained in:
Willy Tarreau 2021-08-26 16:48:53 +02:00
parent 906f7daed1
commit 5ef965606b
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/hlua.c
View File

@ -11372,8 +11372,7 @@ lua_State *hlua_init_state(int thread_num)
/* gL.Tua doesn't support '.' and '-' in the function names, replace it
* by an underscore.
*/
strncpy(trash.area, sf->kw, trash.size);
trash.area[trash.size - 1] = '\0';
strlcpy2(trash.area, sf->kw, trash.size);
for (p = trash.area; *p; p++)
if (*p == '.' || *p == '-' || *p == '+')
*p = '_';
@ -11411,8 +11410,7 @@ lua_State *hlua_init_state(int thread_num)
/* gL.Tua doesn't support '.' and '-' in the function names, replace it
* by an underscore.
*/
strncpy(trash.area, sc->kw, trash.size);
trash.area[trash.size - 1] = '\0';
strlcpy2(trash.area, sc->kw, trash.size);
for (p = trash.area; *p; p++)
if (*p == '.' || *p == '-' || *p == '+')
*p = '_';