RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2024-12-19 18:28:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

CLEANUP: connection: remove the definitions of conn_xprt_{stop,want}_{send,recv}

Browse Source 
This marks the end of the transition from the connection polling states
introduced in 1.5-dev12 and the subscriptions in that arrived in 1.9.
The socket layer can now safely use its FD while all upper layers rely
exclusively on subscriptions. These old functions were removed. Some may
deserve some renaming to improved clarty though. The single call to
conn_xprt_stop_both() was dropped in favor of conn_cond_update_polling()
which already does the same.
This commit is contained in:
Willy Tarreau 2020-02-21 09:58:29 +01:00
parent d1d14c3157
commit 5d4d1806db
2 changed files with 1 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
include/proto/connection.h
View File

@ -179,66 +179,6 @@ static inline void conn_cond_update_polling(struct connection *c)
conn_stop_polling(c);
}
/***** Event manipulation primitives for use by DATA I/O callbacks *****/
/* The __conn_* versions do not propagate to lower layers and are only meant
* to be used by handlers called by the connection handler. The other ones
* may be used anywhere.
*/
static inline void __conn_xprt_want_recv(struct connection *c)
{
if (conn_ctrl_ready(c))
fd_want_recv(c->handle.fd);
}
static inline void __conn_xprt_stop_recv(struct connection *c)
{
if (conn_ctrl_ready(c))
fd_stop_recv(c->handle.fd);
}
static inline void __conn_xprt_want_send(struct connection *c)
{
if (conn_ctrl_ready(c))
fd_want_send(c->handle.fd);
}
static inline void __conn_xprt_stop_send(struct connection *c)
{
if (conn_ctrl_ready(c))
fd_stop_send(c->handle.fd);
}
static inline void __conn_xprt_stop_both(struct connection *c)
{
if (conn_ctrl_ready(c))
fd_stop_both(c->handle.fd);
}
static inline void conn_xprt_want_recv(struct connection *c)
{
__conn_xprt_want_recv(c);
}
static inline void conn_xprt_stop_recv(struct connection *c)
{
__conn_xprt_stop_recv(c);
}
static inline void conn_xprt_want_send(struct connection *c)
{
__conn_xprt_want_send(c);
}
static inline void conn_xprt_stop_send(struct connection *c)
{
__conn_xprt_stop_send(c);
}
static inline void conn_xprt_stop_both(struct connection *c)
{
__conn_xprt_stop_both(c);
}
/* read shutdown, called from the rcv_buf/rcv_pipe handlers when
* detecting an end of connection.
*/

2
src/connection.c
View File

@ -245,7 +245,7 @@ int conn_fd_check(struct connection *conn)
*/
fdtab[fd].linger_risk = 0;
conn->flags |= CO_FL_ERROR | CO_FL_SOCK_RD_SH | CO_FL_SOCK_WR_SH;
__conn_xprt_stop_both(conn);
conn_stop_polling(conn);
return 0;
wait: