RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-02-16 10:36:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: lua/threads: Make lua's tasks sticky to the current thread

Browse Source 
PiBa-NL reported a bug with tasks registered in lua when HAProxy is started with
serveral threads. These tasks have not specific affinity with threads so they
can be woken up on any threads. So, it is impossbile for these tasks to handled
cosockets or applets, because cosockets and applets are sticky on the thread
which created them. It is forbbiden to manipulate a cosocket from another
thread.

So to fix the bug, tasks registered in lua are now sticky to the current
thread. Because these tasks can be registered before threads creation, the
affinity is set the first time a lua's task is processed.

This patch must be backported in HAProxy 1.8.
This commit is contained in:
Christopher Faulet 2018-04-25 10:34:45 +02:00 committed by Willy Tarreau
parent 1e0867cfbc
commit 5bc9972ed8
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/hlua.c
View File

@ -5529,6 +5529,9 @@ static struct task *hlua_process_task(struct task *task)
struct hlua *hlua = task->context;
enum hlua_exec status;
if (task->thread_mask == MAX_THREADS_MASK)
task_set_affinity(task, tid_bit);
/* If it is the first call to the task, we must initialize the
* execution timeouts.
*/