RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-04-11 03:31:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

CLEANUP: pools: simplify the pool expression when no pool was matched in dump

Browse Source 
When dumping pool information, we make a special case of the condition
where the pool couldn't be identified and we consider that it was the
correct one. In the code arrangements brought by commit efc46dede ("DEBUG:
pools: inspect pools on fatal error and dump information found"), a
ternary expression for testing this depends on the "if" block condition
so this can be simplified and will make Coverity happy. This was reported
in GH #2290.
This commit is contained in:
Willy Tarreau 2023-09-13 13:31:41 +02:00
parent c618ed5ff4
commit 5abbae2d3d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/pool.c
View File

@ -1055,7 +1055,7 @@ void pool_inspect_item(const char *msg, struct pool_head *pool, const void *item
/* the pool couldn't be formally verified */
chunk_appendf(&trash, "Other possible callers:\n");
list_for_each_entry(ph, &pools, list) {
if (ph == (the_pool ? the_pool : pool))
if (ph == pool)
continue;
pool_mark = (const void **)(((char *)item) + ph->alloc_sz - sizeof(void*));
if (!may_access(pool_mark))