From 5723b382ed57f9d7b09ddfc449ed4d3072f17e6c Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Wed, 17 May 2023 09:05:20 +0200 Subject: [PATCH] MINOR: stats: report the boot time in "show info" Just like we have the uptime in "show info", let's add the boot time. It's trivial to collect as it's just the difference between the ready date and the start date, and will allow users to monitor this element in order to take action before it starts becoming problematic. Here the boot time is reported in milliseconds, so this allows to even observe sub-second anomalies in startup delays. --- include/haproxy/stats-t.h | 1 + src/stats.c | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/include/haproxy/stats-t.h b/include/haproxy/stats-t.h index 663641615b..07eaf6d502 100644 --- a/include/haproxy/stats-t.h +++ b/include/haproxy/stats-t.h @@ -345,6 +345,7 @@ enum info_field { INF_TAINTED, INF_WARNINGS, INF_MAXCONN_REACHED, + INF_BOOTTIME_MS, /* must always be the last one */ INF_TOTAL_FIELDS diff --git a/src/stats.c b/src/stats.c index 48eb532e09..68adde6c58 100644 --- a/src/stats.c +++ b/src/stats.c @@ -158,6 +158,7 @@ const struct name_desc info_fields[INF_TOTAL_FIELDS] = { [INF_TAINTED] = { .name = "Tainted", .desc = "Experimental features used" }, [INF_WARNINGS] = { .name = "TotalWarnings", .desc = "Total warnings issued" }, [INF_MAXCONN_REACHED] = { .name = "MaxconnReached", .desc = "Number of times an accepted connection resulted in Maxconn being reached" }, + [INF_BOOTTIME_MS] = { .name = "BootTime_ms", .desc = "How long ago it took to parse and process the config before being ready (milliseconds)" }, }; const struct name_desc stat_fields[ST_F_TOTAL_FIELDS] = { @@ -4630,6 +4631,7 @@ int stats_fill_info(struct field *info, int len, uint flags) uint64_t glob_out_bytes, glob_spl_bytes, glob_out_b32; uint up_sec, up_usec; ullong up; + ulong boot; int thr; #ifdef USE_OPENSSL @@ -4654,6 +4656,8 @@ int stats_fill_info(struct field *info, int len, uint flags) up_sec = ns_to_sec(up); up_usec = (up / 1000U) % 1000000U; + boot = tv_ms_remain(&start_date, &ready_date); + if (len < INF_TOTAL_FIELDS) return 0; @@ -4748,6 +4752,7 @@ int stats_fill_info(struct field *info, int len, uint flags) chunk_appendf(out, "%#x", get_tainted()); info[INF_WARNINGS] = mkf_u32(FN_COUNTER, HA_ATOMIC_LOAD(&tot_warnings)); info[INF_MAXCONN_REACHED] = mkf_u32(FN_COUNTER, HA_ATOMIC_LOAD(&maxconn_reached)); + info[INF_BOOTTIME_MS] = mkf_u32(FN_DURATION, boot); return 1; }