RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-04-11 03:31:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: hlua: Don't loop if a lua socket does not consume received data

Browse Source 
If some data are received for a lua socket while the lua script responsible
to consume these data is not ready to do so, for instance because it is
sleeping, the applet is woken up in loop because it never states it will not
consume these data yet.

To fix the issue, in the applet I/O handle, when there are outgoing data, we
always pretend the applet will not consume it. It is the responsibility to
the lua script to reactivate receives by calling Socket.receive() function.

This patch must be backported to every stable version. For 2.4 and older,
si_want_get()/si_cant_get() must be used instead of
applet_will_consume()/applet_wont_consume().
This commit is contained in:
Christopher Faulet 2024-02-16 15:33:44 +01:00
parent 38534d344b
commit 56e73df37d
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/hlua.c
View File

@ -2352,8 +2352,10 @@ static void hlua_socket_handler(struct appctx *appctx)
notification_wake(&ctx->wake_on_write);
/* Wake the tasks which wants to read if the buffer contains data. */
if (co_data(sc_oc(sc)))
if (co_data(sc_oc(sc))) {
notification_wake(&ctx->wake_on_read);
applet_wont_consume(appctx);
}
/* If write notifications are registered, we considers we want
* to write, so we clear the blocking flag.
@ -2622,6 +2624,7 @@ __LJMP static int hlua_socket_receive_yield(struct lua_State *L, int status, lua
co_skip(oc, len + skip_at_end);
/* Don't wait anything. */
applet_will_consume(appctx);
appctx_wakeup(appctx);
/* If the pattern reclaim to read all the data