RepoMirrors
/
haproxy
mirror of http://git.haproxy.org/git/haproxy.git/
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[OPTIM] reduce the number of calls to task_wakeup() 

A test has shown that more than 16% of the calls to task_wakeup()
could be avoided because the task is already woken up. So make it
inline and move the test to the inline part.
This commit is contained in:
Willy Tarreau 2008-08-29 15:26:14 +02:00
parent cb651251f9
commit 4df8206832
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
include/proto/task.h
View File

@ -41,7 +41,13 @@ extern struct task *last_timer; /* optimization: last queued timer */
int init_task();
/* puts the task <t> in run queue <q>, and returns <t> */
struct task *task_wakeup(struct task *t);
struct task *__task_wakeup(struct task *t);
static inline struct task *task_wakeup(struct task *t)
{
if (t->state == TASK_RUNNING)
return t;
return __task_wakeup(t);
}
/* removes the task <t> from the run queue if it was in it.
* returns <t>.

7
src/task.c
View File

@ -131,11 +131,8 @@ int init_task()
* size. A nice value of -1024 sets the task to -run_queue*32, while a nice
* value of 1024 sets the task to run_queue*32.
*/
struct task *task_wakeup(struct task *t)
struct task *__task_wakeup(struct task *t)
{
if (t->state == TASK_RUNNING)
return t;
task_dequeue(t);
run_queue++;
@ -231,7 +228,7 @@ void wake_expired_tasks(int *next)
/* detach the task from the queue and add the task to the run queue */
eb = eb32_next(eb);
task_wakeup(task);
__task_wakeup(task);
}
tree = (tree + 1) & TIMER_TREE_MASK;
} while (((tree - now_tree) & TIMER_TREE_MASK) < TIMER_TREES/2);