From 469fa479501f4807d9983ca46618aba3c4ec8cb7 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Tue, 22 Nov 2022 09:08:23 +0100 Subject: [PATCH] BUILD: listener: fix build warning on global_listener_rwlock without threads The global_listener_rwlock was introduced by recent commit 13e86d947 ("BUG/MEDIUM: listener: Fix race condition when updating the global mngmt task"), but it's declared static and is not used when threads are disabled, thus causing a warning to be emitted in this case. Let's just condition it to thread usage to shut the warning. This will need to be backported where the patch above is backported. --- src/listener.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/listener.c b/src/listener.c index 6cd365acc..c94702a04 100644 --- a/src/listener.c +++ b/src/listener.c @@ -47,7 +47,7 @@ struct bind_kw_list bind_keywords = { /* list of the temporarily limited listeners because of lack of resource */ static struct mt_list global_listener_queue = MT_LIST_HEAD_INIT(global_listener_queue); static struct task *global_listener_queue_task; -static HA_RWLOCK_T global_listener_rwlock; +__decl_thread(static HA_RWLOCK_T global_listener_rwlock); /* listener status for stats */ const char* li_status_st[LI_STATE_COUNT] = {