From 45a45c917ae1cd800ade8344ec4ecdd9de55e9fc Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Fri, 17 May 2024 15:42:46 +0200 Subject: [PATCH] BUG/MINOR: stats: Don't state the 303 redirect response is chunked Start-line flags for 303-See-Other response returned by the stats applet are not properly set. Indeed, the reponse has a "content-length" header but both HTX_SL_F_CHNK and HTX_SL_F_CLEN flags are set. Because of this bug, the reponse is considered as chunked. So, let's remove HTX_SL_F_CHNK flag. And also add HTX_SL_F_BODYLESS flag because there is no payload ("content-length" header is always set to 0). This patch must be backported to all stable versions. On the 2.8 and lower versions, the commit d0b04920d1 ("BUG/MINOR: htpp-ana/stats: Specify that HTX redirect messages have a C-L header") must be backported first. --- src/stats-html.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/stats-html.c b/src/stats-html.c index 367222976..41eaa9e89 100644 --- a/src/stats-html.c +++ b/src/stats-html.c @@ -1571,7 +1571,7 @@ static int stats_send_http_redirect(struct stconn *sc, struct htx *htx) (ctx->flags & STAT_F_NO_REFRESH) ? ";norefresh" : "", scope_txt); - flags = (HTX_SL_F_IS_RESP|HTX_SL_F_VER_11|HTX_SL_F_XFER_LEN|HTX_SL_F_CLEN|HTX_SL_F_CHNK); + flags = (HTX_SL_F_IS_RESP|HTX_SL_F_VER_11|HTX_SL_F_XFER_LEN|HTX_SL_F_CLEN|HTX_SL_F_BODYLESS); sl = htx_add_stline(htx, HTX_BLK_RES_SL, flags, ist("HTTP/1.1"), ist("303"), ist("See Other")); if (!sl) goto full;