From 411aa6daf57495374b41178176d1056d243cc610 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Mon, 21 Mar 2022 12:01:22 +0100 Subject: [PATCH] BUG/MINOR: quic: Non initialized variable in quic_build_post_handshake_frames() could be accessed before being initialized. --- src/xprt_quic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/xprt_quic.c b/src/xprt_quic.c index a386d8106..b9aaeabaf 100644 --- a/src/xprt_quic.c +++ b/src/xprt_quic.c @@ -2983,14 +2983,15 @@ static int quic_build_post_handshake_frames(struct quic_conn *qc) while (node) { struct quic_connection_id *cid; + + cid = eb64_entry(&node->node, struct quic_connection_id, seq_num); if (cid->seq_num.key >= max) break; - cid = eb64_entry(&node->node, struct quic_connection_id, seq_num); - node = eb64_next(node); if (cid->seq_num.key < first) continue; + node = eb64_next(node); ebmb_delete(&cid->node); eb64_delete(&cid->seq_num); pool_free(pool_head_quic_connection_id, cid);