From 3ebe7bef8d8b55e98e807b1d15b5b3ba64c2dc0a Mon Sep 17 00:00:00 2001 From: Aurelien DARRAGON Date: Fri, 22 Dec 2023 14:42:22 +0100 Subject: [PATCH] CLEANUP: server: remove ambiguous check in srv_update_addr_port() A leftover check was left by recent patch series about server addr:svc_port propagation: a check on (msg) being set was performed in srv_update_addr_port(), but msg is always set, so the check is not needed and confuses coverity (See GH #2399) --- src/server.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/server.c b/src/server.c index 6a082fcb0f..bc838b3b98 100644 --- a/src/server.c +++ b/src/server.c @@ -4167,8 +4167,7 @@ const char *srv_update_addr_port(struct server *s, const char *addr, const char * s->svc_port is only relevant under inet context */ if ((s->addr.ss_family != AF_INET) && (s->addr.ss_family != AF_INET6)) { - if (msg) - chunk_printf(msg, "Update for the current server address family is only supported through configuration file."); + chunk_printf(msg, "Update for the current server address family is only supported through configuration file."); goto out; }