BUG/MEDIUM: pattern: a typo breaks automatic acl/map numbering

Dmitry Sivachenko reported that nice warning :
src/pattern.c:2243:43: warning: if statement has empty body [-Wempty-body]
                                if (&ref2->list == &pattern_reference);
                                                                      ^
src/pattern.c:2243:43: note: put the semicolon on a separate line to silence
      this warning

It was merged as is with the code from commit af5a29d ("MINOR: pattern:
Each pattern is identified by unique id").

So it looks like we can reassign an ID which is still in use because of
this.
This commit is contained in:
Willy Tarreau 2014-04-26 12:37:25 +02:00
parent 8860dcd70a
commit 3b78696858
1 changed files with 1 additions and 1 deletions

View File

@ -2240,7 +2240,7 @@ void pattern_finalize_config(void)
break;
}
}
if (&ref2->list == &pattern_reference);
if (&ref2->list == &pattern_reference)
break;
}