From 374edc70ba7d1c81fcaa29457eac5dffd1caf48d Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Thu, 1 Apr 2021 17:01:43 +0200 Subject: [PATCH] CLEANUP: vars: always pre-initialize smp in vars_parse_cli_get_var() In issue #1200 Coverity believes we may use an uninitialized field smp.sess here while it's not possible because the returned variable necessarily matches SCOPE_PROC hence smp.sess is not used. But it cannot see this and it could be confusing if the code later evolved into something more complex. That's not a critical path so let's first reset the sample. --- src/vars.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vars.c b/src/vars.c index cf92005f59..980b669c3a 100644 --- a/src/vars.c +++ b/src/vars.c @@ -873,7 +873,7 @@ static int vars_parse_global_set_var(char **args, int section_type, struct proxy static int vars_parse_cli_get_var(char **args, char *payload, struct appctx *appctx, void *private) { struct vars *vars; - struct sample smp; + struct sample smp = { }; int i; if (!cli_has_level(appctx, ACCESS_LVL_OPER))