RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-03-10 05:21:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

CLEANUP: quic: Remove a useless TLS related variable from quic_conn_io_cb().

Browse Source 
<ssl_err> was defined and used but its value is never modified after having
been initialized. It is definitively useless.
This commit is contained in:
Frédéric Lécaille 2023-07-13 11:56:36 +02:00
parent cf2368a3d5
commit 367ece4add
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/quic_conn.c
View File

@ -430,12 +430,9 @@ static void quic_trace(enum trace_level level, uint64_t mask, const struct trace
if (mask & QUIC_EV_CONN_IO_CB) { if (mask & QUIC_EV_CONN_IO_CB) {
const enum quic_handshake_state *state = a2; const enum quic_handshake_state *state = a2;
const int *err = a3;
if (state) if (state)
chunk_appendf(&trace_buf, " state=%s", quic_hdshk_state_str(*state)); chunk_appendf(&trace_buf, " state=%s", quic_hdshk_state_str(*state));
if (err)
chunk_appendf(&trace_buf, " err=%s", ssl_error_str(*err));
} }
if (mask & (QUIC_EV_CONN_TRMHP|QUIC_EV_CONN_ELRMHP|QUIC_EV_CONN_SPKT)) { if (mask & (QUIC_EV_CONN_TRMHP|QUIC_EV_CONN_ELRMHP|QUIC_EV_CONN_SPKT)) {
@ -5103,7 +5100,7 @@ static int qc_need_sending(struct quic_conn *qc, struct quic_enc_level *qel)
/* QUIC connection packet handler task. */ /* QUIC connection packet handler task. */
struct task *quic_conn_io_cb(struct task *t, void *context, unsigned int state) struct task *quic_conn_io_cb(struct task *t, void *context, unsigned int state)
{ {
int ret, ssl_err; int ret;
struct quic_conn *qc = context; struct quic_conn *qc = context;
enum quic_tls_enc_level tel, next_tel; enum quic_tls_enc_level tel, next_tel;
struct quic_enc_level *qel, *next_qel; struct quic_enc_level *qel, *next_qel;
@ -5126,7 +5123,6 @@ struct task *quic_conn_io_cb(struct task *t, void *context, unsigned int state)
goto out; goto out;
} }
ssl_err = SSL_ERROR_NONE;
zero_rtt = st < QUIC_HS_ST_COMPLETE && zero_rtt = st < QUIC_HS_ST_COMPLETE &&
quic_tls_has_rx_sec(eqel) && quic_tls_has_rx_sec(eqel) &&
(!LIST_ISEMPTY(&eqel->rx.pqpkts) || qc_el_rx_pkts(eqel)); (!LIST_ISEMPTY(&eqel->rx.pqpkts) || qc_el_rx_pkts(eqel));
@ -5256,7 +5252,7 @@ struct task *quic_conn_io_cb(struct task *t, void *context, unsigned int state)
quic_nictx_free(qc); quic_nictx_free(qc);
} }
TRACE_PROTO("ssl error", QUIC_EV_CONN_IO_CB, qc, &st, &ssl_err); TRACE_PROTO("ssl error", QUIC_EV_CONN_IO_CB, qc, &st);
TRACE_LEAVE(QUIC_EV_CONN_IO_CB, qc); TRACE_LEAVE(QUIC_EV_CONN_IO_CB, qc);
return t; return t;
} }