RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2024-12-17 17:04:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: hlua: Don't strip last non-LWS char in hlua_pushstrippedstring()

Browse Source 
hlua_pushstrippedstring() function strips leading and trailing LWS
characters. But the result length it too short by 1 byte. Thus the last
non-LWS character is stripped. Note that a string containing only LWS
characters resulting to a stipped string with an invalid length (-1). This
leads to a lua runtime error.

This bug was reported in the issue #1155. It must be backported as far as
1.7.
This commit is contained in:
Christopher Faulet 2021-03-03 19:36:51 +01:00
parent a47dfab673
commit 2ec4e3c1ac
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/hlua_fcn.c
View File

@ -172,12 +172,13 @@ int hlua_fcn_pushfield(lua_State *L, struct field *field)
const char *hlua_pushstrippedstring(lua_State *L, const char *str)
{
const char *p;
const char *e;
int l;
for (p = str; HTTP_IS_LWS(*p); p++);
for (e = p + strlen(p) - 1; e > p && HTTP_IS_LWS(*e); e--);
return lua_pushlstring(L, p, e - p);
for (l = strlen(p); l && HTTP_IS_LWS(p[l-1]); l--);
return lua_pushlstring(L, p, l);
}
/* The three following functions are useful for adding entries