From 2bde0d64ddf0e32257444f14e69adea8f899b74b Mon Sep 17 00:00:00 2001 From: Aurelien DARRAGON Date: Tue, 4 Jun 2024 15:52:23 +0200 Subject: [PATCH] CLEANUP: hlua: simplify ambiguous lua_insert() usage in hlua_ctx_resume() 'lua_insert(lua->T, -lua_gettop(lua->T))' is actually used to rotate the top value with the bottom one, thus the code was overkill and the comment was actually misleading, let's fix that by using explicit equivalent form (absolute index). It may be backported with 5508db9a2 ("BUG/MINOR: hlua: fix unsafe lua_tostring() usage with empty stack") to all stable versions to ease code maintenance. --- src/hlua.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/hlua.c b/src/hlua.c index f108c6ed8..8434ed73a 100644 --- a/src/hlua.c +++ b/src/hlua.c @@ -2087,8 +2087,8 @@ resume_execution: hlua_pushfstring_safe(lua->T, "[state-id %d] unknown runtime error from %s", lua->state_id, trace); - /* Move the error msg at the top and then empty the stack except last msg */ - lua_insert(lua->T, -lua_gettop(lua->T)); + /* Move the error msg at the bottom and then empty the stack except last msg */ + lua_insert(lua->T, 1); lua_settop(lua->T, 1); ret = HLUA_E_ERRMSG; break; @@ -2113,8 +2113,8 @@ resume_execution: hlua_pushfstring_safe(lua->T, "[state-id %d] message handler error", lua->state_id); - /* Move the error msg at the top and then empty the stack except last msg */ - lua_insert(lua->T, -lua_gettop(lua->T)); + /* Move the error msg at the bottom and then empty the stack except last msg */ + lua_insert(lua->T, 1); lua_settop(lua->T, 1); ret = HLUA_E_ERRMSG; break;