CLEANUP: connection: Stop directly setting an ist's .ptr

Instead replace the complete `ist` by the value returned from `ist2`.

This was noticed during review of issue #549.
This commit is contained in:
Tim Duesterhus 2020-03-14 13:07:05 +01:00 committed by Willy Tarreau
parent e4d42551bd
commit 2b7f6c22d8

View File

@ -760,7 +760,7 @@ int conn_recv_proxy(struct connection *conn, int flag)
if (tlv.len > UNIQUEID_LEN)
goto bad_header;
conn->proxy_unique_id.ptr = pool_alloc(pool_head_uniqueid);
conn->proxy_unique_id = ist2(pool_alloc(pool_head_uniqueid), 0);
if (!isttest(conn->proxy_unique_id))
goto fail;
if (istcpy(&conn->proxy_unique_id, tlv, UNIQUEID_LEN) < 0) {