RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-04-11 03:31:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: cache: make sure not to cache requests with absolute-uri

Browse Source 
If a request contains an absolute URI and gets its Host header field
rewritten, or just the request's URI without touching the Host header
field, it can lead to different Host and authority parts. The cache
will always concatenate the Host and the path while a server behind
would instead ignore the Host and use the authority found in the URI,
leading to incorrect content possibly being cached.

Let's simply refrain from caching absolute requests for now, which
also matches what the comment at the top of the function says. Later
we can improve this by having a special handling of the authority.

This should be backported as far as 1.8.
This commit is contained in:
Willy Tarreau 2019-10-07 14:06:34 +02:00
parent 5c0f859c27
commit 22c6107dba
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cache.c
View File

@ -1082,8 +1082,8 @@ int sha1_hosturi(struct stream *s)
chunk_memcat(trash, ctx.value.ptr, ctx.value.len);
sl = http_get_stline(htx);
path = http_get_path(htx_sl_req_uri(sl));
if (!path.ptr)
path = htx_sl_req_uri(sl); // whole uri
if (!path.len || *path.ptr != '/')
return 0;
chunk_memcat(trash, path.ptr, path.len);